Skip to content

cleanup: Remove unnecessary Array abstraction#821

Merged
Veykril merged 1 commit intosalsa-rs:masterfrom
Veykril:veykril/push-tyrzyyzoryrm
Apr 28, 2025
Merged

cleanup: Remove unnecessary Array abstraction#821
Veykril merged 1 commit intosalsa-rs:masterfrom
Veykril:veykril/push-tyrzyyzoryrm

Conversation

@Veykril
Copy link
Member

@Veykril Veykril commented Apr 28, 2025

No description provided.

@netlify
Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 9781cbe
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/680f2cf53df0e300086050c7

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 28, 2025

CodSpeed Performance Report

Merging #821 will improve performances by 5.56%

Comparing Veykril:veykril/push-tyrzyyzoryrm (9781cbe) with master (201a8dd)

Summary

⚡ 6 improvements
✅ 6 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
accumulator 4.2 ms 3.9 ms +5.37%
amortized[Input] 3.4 µs 3.2 µs +4.11%
amortized[InternedInput] 3.3 µs 3.2 µs +4.18%
amortized[SupertypeInput] 4.1 µs 3.9 µs +5.18%
new[Input] 10.1 µs 9.6 µs +5.56%
new[InternedInput] 5.6 µs 5.3 µs +4.13%

@MichaReiser
Copy link
Contributor

I wonder what broke codspeed. Something is definitely off now (or salsa becomes 5% faster with every PR :P)

@Veykril Veykril enabled auto-merge April 28, 2025 07:31
@Veykril Veykril added this pull request to the merge queue Apr 28, 2025
Merged via the queue into salsa-rs:master with commit 4fa0ee8 Apr 28, 2025
11 checks passed
@Veykril Veykril deleted the veykril/push-tyrzyyzoryrm branch April 28, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants